Comments on: Word Counting in C++: Implementing a Simple Word Counter

By: Jonathan Boccara

Jonathan Boccara — Sat, 10 Nov 2018 19:09:00 +0000

In reply to Malcolm Parsons. Excellent, thanks!

By: Malcolm Parsons

Malcolm Parsons — Fri, 09 Nov 2018 12:29:00 +0000

Pass token_compress_on to boost::split() to avoid the empty strings.

By: M Limber

M Limber — Fri, 12 Oct 2018 19:32:00 +0000

I only wish you had included tests as part of your first iteration. 🙂 That helps you keep yourself honest as you move forward and is an excellent way to learn to write quality code, even if you’re not doing TDD. Catch2 makes it so easy!

By: jft

jft — Fri, 12 Oct 2018 16:32:00 +0000

In reply to maxim1000.

… and also that you might want to ignore certain words such as std, auto, const etc etc. Also knowing the line numbers for the words would also be useful IMO.

Possibly not an issue with the size of the intended program files, but the algorithm is not optimised for the best performance. The code is creating a vector, a map then another vector which is sorted! For a file of several Mbs with thousands of different words, this is slooooooow…

By: maxim1000

maxim1000 — Fri, 12 Oct 2018 09:12:00 +0000

getWordCount function return type WordCount – looks normal, there is a temporary variable wordCount inside of the function getWordCount – natural. But the function returns sortedWordCount.

The names themselves suggest that there is something strange here 🙂 Digging into such strange places may hint some problems.

[Please, add “IMHO” to each of the following sentences]

First problem is that we use an undocumented feature of getWordCount inside of print function – order of words in the resulting container. getWordCount returns WordCount, not SortedWordCount and there is nothing suggesting that it will be sorted.

Second problem is that sorting looks more like something related to how we show information, not how we get it. We may want to show longest names used at least 10 times, or most popular one-letter symbol. It seems to naturally belong to print, not getWordCount.

By: Bartlomiej Filipek

Bartlomiej Filipek — Fri, 12 Oct 2018 06:51:00 +0000

little hack from my side 🙂
coliru stores your code in “main.cpp” in the directory with the executable file.

So you can just read “main.cpp” into your “code” string.

http://coliru.stacked-crooked.com/a/1227cdfdaf3c8da7