Lol. Fixed 🙂

“How to Remove Elements from a Sequence Container in C++” is duplicated 🙂

Done! https://www.fluentcpp.com/STL

Yes – but then you have two iterations over the container v, rather than one. Whether this is a performance issue or not would need to be determined.

The fact that you feel an urge to add a comment should be a hint that the code is not as clean as one would want.

I guess I would just do

v.erase(
    remove(
        v.begin(),
        v.end(),
        pred),
    v.end());

for (auto&& x : v)
{
    f(t);
}

You mean using remove_if()? Why is this a hack? You are iterating the container once (via remove_if() ) and testing each element once. So performance wise I don’t see this being bettered. You could do it using an explicit iterator in a for loop, but then you have to deal with the end iterator changing on a delete which code-wise could look even more ‘hacky’. Range for and for-each are no good here as you can’t adjust the end iterator as you would need to when removing element(s) in a loop. I suppose the ‘hack’ is that you are calling a function within a container deletion – which might be unexpected. Personally I like the code and would just put in a simple comment before it – something like

//Note function called within remove_if() lambda.

You are very right! Thanks for you correction.

I know you can do this:

v.erase(
    remove(
        v.begin(),
        v.end(),
        [](const T& t)
        {
            if (pred(t))
            {
                f(t);
                return false;
            }
            else
            {
                return true;
            }
        }),
    v.end());

But it feels like a hack.