Comments on: Make Your Containers Follow the Conventions of the STL

By: Tien Do

Tien Do — Wed, 05 Sep 2018 02:30:00 +0000

In reply to Simon Brand. But one of the points here is our containers should have size(), even not count() or length()

By: Tien Do

Tien Do — Wed, 05 Sep 2018 02:20:00 +0000

I haven’t created a generic container class myself but I learned more about STL from this article. Thanks.

By: Simon Brand

Simon Brand — Wed, 25 Apr 2018 08:21:00 +0000

In reply to Jonathan Boccara.

I think
“`
using std::size;
if (size(range1) != size(range2))
“`
would be better. That will work with containers which have size as a member function, standard library containers with non-member size, and other library containers which have non-member size declared in their namespace.

By: Jonathan Boccara

Jonathan Boccara — Wed, 25 Apr 2018 05:52:00 +0000

In reply to Malcolm Parsons. Thanks Malcom, I've worked your remark into the article.

By: Jonathan Boccara

Jonathan Boccara — Wed, 25 Apr 2018 05:49:00 +0000

In reply to Miguel Raggi. Thanks for your suggestion Miguel, I've added to the article the code snippet that you're proposing.

By: Miguel Raggi

Miguel Raggi — Wed, 25 Apr 2018 00:22:00 +0000

Fantastic article! I would also suggest adding the proper “using” typedef’s:

class MyContainer
{
public:
using value_type = blah;
using iterator = blah;
…
}
and so on, depending on the type of container.

By: Malcolm Parsons

Malcolm Parsons — Tue, 24 Apr 2018 14:23:00 +0000

if (range1.size() != range2.size()) return false;

This should use std::size()



By: Liquidify
Liquidify — Tue, 24 Apr 2018 08:07:00 +0000
It would be really helpful if there were readable implementations of all the stl containers, and for that matter for all the other stl things too.  They don’t even have to be “good” versions.  Just working versions that handle basic types and look more like pseudo code than the standardeese that exists.  It is a lot easier to write code in a style or following a convention when there are simple human readable examples.