Comments on: How to Insulate a Toxic Api from the Rest of Your Code https://www.fluentcpp.com/2017/06/30/insulating-a-toxic-api-from-the-rest-of-your-code/ Jonathan Boccara's blog Mon, 02 Oct 2017 20:28:38 +0000 hourly 1 https://wordpress.org/?v=6.5.3 By: Jonathan Boccara https://www.fluentcpp.com/2017/06/30/insulating-a-toxic-api-from-the-rest-of-your-code/#comment-378 Tue, 04 Jul 2017 09:46:00 +0000 https://www.fluentcpp.com/?p=1024#comment-378 In reply to descartes0.

Well here public inheritance has the advantage of mutualizing the common interface without adding using declaration in the implementation.
But you’re right, the base class shouldn’t hold the ugly one by value, it should rather hold it by a forward delcared pointer. Someone else also had this same remark. I will amend the post in that sense.

]]> By: descartes0 https://www.fluentcpp.com/2017/06/30/insulating-a-toxic-api-from-the-rest-of-your-code/#comment-369 Fri, 30 Jun 2017 18:24:00 +0000 https://www.fluentcpp.com/?p=1024#comment-369 So, why not use private inheritance (“is-implemented-in-terms-of”), or pImpl idiom? Preventing polymorphic behavior of the base class _outside_ of the classes, but reusing the base’s functionality internally is exactly what private inheritance is meant for.

]]>