Comments on: set_aggregate, set_segregate: higher-level algorithms on sets https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/ Jonathan Boccara's blog Thu, 27 Apr 2017 06:02:00 +0000 hourly 1 https://wordpress.org/?v=6.5.4 By: Vladislav Kaplan https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-230 Thu, 27 Apr 2017 06:02:00 +0000 https://www.fluentcpp.com/?p=522#comment-230 Thank you

]]> By: Puneet Agrawal https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-96 Wed, 22 Feb 2017 05:06:00 +0000 https://www.fluentcpp.com/?p=522#comment-96 In reply to Jonathan Boccara.

look like my previous comment is lost (or I didn’t saved that). Anyhow, here i was talking about a zip function like in python to combine values from two or more containers in a single container of pair or tuples. I believe, if we work with ranges (or iterators) that should work with a non-contiguous input also. A very naive implementation using std::inner_product() can be found at http://melpon.org/wandbox/permlink/6HkoTPjwDmtBmvtx

I think this can be made more generalized by using variadic templates and tuples.

]]> By: Jonathan Boccara https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-93 Tue, 14 Feb 2017 00:58:00 +0000 https://www.fluentcpp.com/?p=522#comment-93 In reply to Puneet Agrawal.

Hi Puneet, thanks for the suggestion.
set_segregate can certainly have an argument that decides whether or not to take the right value, I’ve actually tried to used that in the GitHub project.
The zip idea is interesting, how would you go about using it here? I reckon the elements that end up in the common output are not necessarily contiguous in the input, is it a problem for using zip?

]]> By: Puneet Agrawal https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-92 Mon, 13 Feb 2017 10:56:00 +0000 https://www.fluentcpp.com/?p=522#comment-92 for set_segregate, instead of using two different function, can we just enhance the first version to have an optional argument from user to contain the common value from right too. User can then combine (zip) the values together. We are sure that the length of both the output ranges will be same, so zip can be easily done.

]]> By: Jonathan Boccara https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-91 Sun, 12 Feb 2017 01:11:00 +0000 https://www.fluentcpp.com/?p=522#comment-91 In reply to bb8.

Well spotted, I made the correction in the article. The github was already good but I added a unit test to take the corresponding case into account thanks to your remark 🙂

]]> By: bb8 https://www.fluentcpp.com/2017/02/09/set-aggregate-set-seggregate-higher-level-algorithms-on-sets/#comment-90 Fri, 10 Feb 2017 11:57:00 +0000 https://www.fluentcpp.com/?p=522#comment-90 in the first set_seggregate(), when the element is contained in both sets, both iterators need to be incremented

]]>